This run took 10 seconds.
From e664efbb917b7e0b14c38b425034f059c3294a16 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 17 Mar 2024 22:08:48 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
Change-Id: I23378c93621a97aa73077004493cdb644eba5f55
---
composer.json | 7 ++++++-
includes/PageSchemas.php | 8 ++++----
includes/specials/PSEditSchema.php | 2 +-
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/composer.json b/composer.json
index 103c49a..f471847 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "41.0.0",
+ "mediawiki/mediawiki-codesniffer": "43.0.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.3.2"
@@ -16,5 +16,10 @@
"phpcbf"
],
"phpcs": "phpcs -sp"
+ },
+ "config": {
+ "allow-plugins": {
+ "dealerdirect/phpcodesniffer-composer-installer": true
+ }
}
}
diff --git a/includes/PageSchemas.php b/includes/PageSchemas.php
index 8e20f76..ab0836a 100644
--- a/includes/PageSchemas.php
+++ b/includes/PageSchemas.php
@@ -112,7 +112,7 @@ END;
if ( !is_array( $returnVals ) || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getSchemaDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'schemaExtensionRow', $label, $elementName, $bgColor );
@@ -153,7 +153,7 @@ END;
if ( !is_array( $returnVals ) || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getTemplateDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'fieldExtensionRow', $label, $elementName, $bgColor );
@@ -199,7 +199,7 @@ END;
if ( $returnVals == null || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getFieldDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'fieldExtensionRow', $label, $elementName, $bgColor );
@@ -227,7 +227,7 @@ END;
if ( $returnVals == null || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getPageSectionDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'fieldExtensionRow', $label, $elementName, $bgColor );
diff --git a/includes/specials/PSEditSchema.php b/includes/specials/PSEditSchema.php
index 0d051a0..1c93a55 100644
--- a/includes/specials/PSEditSchema.php
+++ b/includes/specials/PSEditSchema.php
@@ -240,7 +240,7 @@ class PSEditSchema extends IncludableSpecialPage {
* Returns the HTML for a form section coming from a specific extension.
*/
function printFieldHTMLForExtension( $valuesFromExtension, $label, $color ) {
- list( $html, $hasExistingValues ) = $valuesFromExtension;
+ [ $html, $hasExistingValues ] = $valuesFromExtension;
return $this->printFormSection( $label, $color, $html, null, $hasExistingValues );
}
--
2.39.2
$ date
--- stdout ---
Sun Mar 17 22:08:40 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-PageSchemas.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
d879b5deecb5c3a4f46d2d3d737a096ae363683e refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 446,
"optional": 0,
"peer": 7,
"peerOptional": 0,
"total": 446
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 19 installs, 0 updates, 0 removals
- Locking composer/semver (3.3.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking mediawiki/mediawiki-codesniffer (v41.0.0)
- Locking mediawiki/minus-x (1.1.1)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.3.2)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.7.2)
- Locking symfony/console (v5.4.36)
- Locking symfony/deprecation-contracts (v3.4.0)
- Locking symfony/polyfill-ctype (v1.29.0)
- Locking symfony/polyfill-intl-grapheme (v1.29.0)
- Locking symfony/polyfill-intl-normalizer (v1.29.0)
- Locking symfony/polyfill-mbstring (v1.29.0)
- Locking symfony/polyfill-php73 (v1.29.0)
- Locking symfony/polyfill-php80 (v1.29.0)
- Locking symfony/service-contracts (v3.4.1)
- Locking symfony/string (v6.4.4)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 19 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing symfony/polyfill-php80 (v1.29.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.7.2): Extracting archive
- Installing symfony/polyfill-mbstring (v1.29.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.3.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v41.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.29.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.29.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.29.0): Extracting archive
- Installing symfony/string (v6.4.4): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.4.1): Extracting archive
- Installing symfony/polyfill-php73 (v1.29.0): Extracting archive
- Installing symfony/deprecation-contracts (v3.4.0): Extracting archive
- Installing symfony/console (v5.4.36): Extracting archive
- Installing mediawiki/minus-x (1.1.1): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.3.2): Extracting archive
0/19 [>---------------------------] 0%
18/19 [==========================>-] 94%
19/19 [============================] 100%
4 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
13 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 41.0.0 -> 43.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 3 updates, 0 removals
- Upgrading composer/semver (3.3.2 => 3.4.0)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0)
- Locking phpcsstandards/phpcsextra (1.1.2)
- Locking phpcsstandards/phpcsutils (1.0.9)
- Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 3 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.9): Extracting archive
- Installing phpcsstandards/phpcsextra (1.1.2): Extracting archive
- Upgrading composer/semver (3.3.2 => 3.4.0): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0): Extracting archive
0/4 [>---------------------------] 0%
4/4 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
{'MediaWiki.Commenting.FunctionComment.MissingReturn', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate', 'Squiz.Scope.MethodScope.Missing', 'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'MediaWiki.Commenting.FunctionComment.MissingParamTag', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic'}
Tests fail!
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/includes/PageSchemas.php 4 21
/src/repo/includes/specials/PSEditSchema.php 1 51
----------------------------------------------------------------------
A TOTAL OF 5 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------
Time: 447ms; Memory: 6MB
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp
--- stdout ---
PHP 8.2.7 | 10 parallel jobs
............. 13/13 (100 %)
Checked 13 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
...................
All good!
............. 13 / 13 (100%)
Time: 254ms; Memory: 6MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 446,
"optional": 0,
"peer": 7,
"peerOptional": 0,
"total": 446
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpr9s37qbq
--- stdout ---
[master e664efb] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
3 files changed, 11 insertions(+), 6 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From e664efbb917b7e0b14c38b425034f059c3294a16 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 17 Mar 2024 22:08:48 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
Change-Id: I23378c93621a97aa73077004493cdb644eba5f55
---
composer.json | 7 ++++++-
includes/PageSchemas.php | 8 ++++----
includes/specials/PSEditSchema.php | 2 +-
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/composer.json b/composer.json
index 103c49a..f471847 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "41.0.0",
+ "mediawiki/mediawiki-codesniffer": "43.0.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.3.2"
@@ -16,5 +16,10 @@
"phpcbf"
],
"phpcs": "phpcs -sp"
+ },
+ "config": {
+ "allow-plugins": {
+ "dealerdirect/phpcodesniffer-composer-installer": true
+ }
}
}
diff --git a/includes/PageSchemas.php b/includes/PageSchemas.php
index 8e20f76..ab0836a 100644
--- a/includes/PageSchemas.php
+++ b/includes/PageSchemas.php
@@ -112,7 +112,7 @@ END;
if ( !is_array( $returnVals ) || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getSchemaDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'schemaExtensionRow', $label, $elementName, $bgColor );
@@ -153,7 +153,7 @@ END;
if ( !is_array( $returnVals ) || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getTemplateDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'fieldExtensionRow', $label, $elementName, $bgColor );
@@ -199,7 +199,7 @@ END;
if ( $returnVals == null || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getFieldDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'fieldExtensionRow', $label, $elementName, $bgColor );
@@ -227,7 +227,7 @@ END;
if ( $returnVals == null || count( $returnVals ) != 2 ) {
continue;
}
- list( $elementName, $values ) = $returnVals;
+ [ $elementName, $values ] = $returnVals;
$label = call_user_func( [ $psHandlerClass, 'getPageSectionDisplayString' ] );
$bgColor = call_user_func( [ $psHandlerClass, 'getDisplayColor' ] );
$text .= self::tableRowHTML( 'fieldExtensionRow', $label, $elementName, $bgColor );
diff --git a/includes/specials/PSEditSchema.php b/includes/specials/PSEditSchema.php
index 0d051a0..1c93a55 100644
--- a/includes/specials/PSEditSchema.php
+++ b/includes/specials/PSEditSchema.php
@@ -240,7 +240,7 @@ class PSEditSchema extends IncludableSpecialPage {
* Returns the HTML for a form section coming from a specific extension.
*/
function printFieldHTMLForExtension( $valuesFromExtension, $label, $color ) {
- list( $html, $hasExistingValues ) = $valuesFromExtension;
+ [ $html, $hasExistingValues ] = $valuesFromExtension;
return $this->printFormSection( $label, $color, $html, null, $hasExistingValues );
}
--
2.39.2
--- end ---